ci: add sync-beta-upstream #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shumpei Wakabayashi <[email protected]>
|
Thank you for the PR! Can you explain with an example of what is the proposed process and how the PR will work in it. As I understood, all products will be forked from vanilla and will be getting updates from vanilla. But the addition is that all products will also be giving back their updates to the vanilla version. Is my understanding of your idea correct? |
|
@dkoldaev
|
shmpwk
added a commit
that referenced
this pull request
Jun 25, 2024
* ci: add sync-beta-upstream Signed-off-by: Shumpei Wakabayashi <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yuki-takagi-66
pushed a commit
that referenced
this pull request
Aug 1, 2024
* ci: add sync-beta-upstream (#459) * ci: add sync-beta-upstream Signed-off-by: Shumpei Wakabayashi <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix for v3.1.0 Signed-off-by: Shumpei Wakabayashi <[email protected]> --------- Signed-off-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This workflow is intended for the use in the repositories created by forking tier4/autoware_launch.
It means this PR does not work in tier4/autoware_launch.
base-branch: beta/<version>andsync-target-branch: beta/<version>such asbase-branch: beta/v3.0.0andsync-target-branch: beta/v0.29.0in each product.Backgound
Currently, in our product release test, we only develop our own product such as xx1.
But those commits should be given back to the vanilla pilot-auto and should be shared with the other products.
Here, we propose to create rule: In product development, commit vanilla pilot-auto first and then syncronize with each product.
We need to develop sync CI to syncronize our product with
pilot-autoandautoware_launch. This PR is the one for it.Related links
INTERNAL_LINK
Tests performed
We have a similar CI: https://github.com/tier4/autoware_launch/blob/tier4/main/.github/workflows/sync-tier4-upstream.yaml
It is commonly used and I believe it can replace our test.
Notes for reviewers
Effects on system behavior
base-branch: beta/<version>andsync-target-branch: beta/<version>such asbase-branch: beta/v3.0.0andsync-target-branch: beta/v0.29.0.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.